Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(negative): wait_for_workload_pods_stable #1821

Merged

Conversation

c3y1huang
Copy link
Collaborator

Which issue(s) this PR fixes:

Issue longhorn/longhorn#8193

What this PR does / why we need it:

Check whether the retry count exceeds the WAIT_FOR_POD_STABLE_MAX_RETRY instead of verifying the exact match to avoid the loop.

Special notes for your reviewer:

None

Additional documentation or context

longhorn/longhorn#8193 (comment)

longhorn/longhorn-8193

Signed-off-by: Chin-Ya Huang <[email protected]>
Copy link
Member

@yangchiu yangchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@innobead innobead merged commit 1478037 into longhorn:master Mar 19, 2024
5 checks passed
@c3y1huang c3y1huang deleted the fix-wait_for_workload_pods_stable branch March 19, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants